Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model for Eltex MES #2119

Merged
merged 7 commits into from
Jun 11, 2020
Merged

Model for Eltex MES #2119

merged 7 commits into from
Jun 11, 2020

Conversation

kastakhov
Copy link
Contributor

@kastakhov kastakhov commented Jun 4, 2020

Pre-Request Checklist

  • Passes rubocop code analysis (try rubocop --auto-correct)
  • Tests added or adapted (try rake test)
  • Changes are reflected in the documentation
  • User-visible changes appended to CHANGELOG.md

Description

tested with MES2324FB

tested with MES2324FB
@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2020

Codecov Report

Merging #2119 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2119   +/-   ##
=======================================
  Coverage   63.32%   63.32%           
=======================================
  Files          30       30           
  Lines        1497     1497           
=======================================
  Hits          948      948           
  Misses        549      549           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb6cd0b...6315d23. Read the comment docs.

@wk
Copy link
Contributor

wk commented Jun 11, 2020

Looks good! It'll need an entry in CHANGELOG.md (documenting the change), an entry in Supported-OS-Types.md (documenting the device support), and it'd be great if a comment was included at the top of the model documenting the device name and firmware version on which this was tested as part of this PR before it can be pulled.

@wk wk mentioned this pull request Jun 11, 2020
4 tasks
@wk
Copy link
Contributor

wk commented Jun 11, 2020

Thanks, that was quick! Pulling this in.

@wk wk merged commit f28083f into ytti:master Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants