Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EdgeCOS: add ES3526XA-V2 #2125

Merged
merged 1 commit into from
Jun 11, 2020
Merged

EdgeCOS: add ES3526XA-V2 #2125

merged 1 commit into from
Jun 11, 2020

Conversation

moisseev
Copy link
Contributor

@moisseev moisseev commented Jun 9, 2020

that doesn't support terminal command

Pre-Request Checklist

  • Passes rubocop code analysis (try rubocop --auto-correct)
  • Tests added or adapted (try rake test)
  • Changes are reflected in the documentation
  • User-visible changes appended to CHANGELOG.md

Description

that doesn't support `terminal` command
@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2020

Codecov Report

Merging #2125 into master will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2125      +/-   ##
==========================================
- Coverage   63.32%   63.19%   -0.14%     
==========================================
  Files          30       30              
  Lines        1497     1497              
==========================================
- Hits          948      946       -2     
- Misses        549      551       +2     
Impacted Files Coverage Δ
lib/oxidized/output/git.rb 17.35% <0.00%> (-1.66%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9d3715...1797823. Read the comment docs.

@wk
Copy link
Contributor

wk commented Jun 11, 2020

It's generally preferred to disable the pager after login over attempting to capture it; is there no command offered by this device to either extend output length in lines beyond a reasonable maximum or to disable the pager itself completely?

@moisseev
Copy link
Contributor Author

Unfortunately this particular switch model is not offering any control on pager. ;(

@wk
Copy link
Contributor

wk commented Jun 11, 2020

Unfortunate. Pulling this in, thanks for the PR!

@wk wk merged commit bb6cd0b into ytti:master Jun 11, 2020
@moisseev moisseev deleted the edgecos branch October 23, 2020 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants