Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LANCOM support #2139

Merged
merged 11 commits into from
Jul 6, 2020
Merged

Add LANCOM support #2139

merged 11 commits into from
Jul 6, 2020

Conversation

systeembeheerder
Copy link
Contributor

@systeembeheerder systeembeheerder commented Jun 22, 2020 •
edited
Loading

Description

Adds support for LANCOM routers

Closes issue #2137

edit: somehow this pull request contains to much commits...

systeembeheerder and others added 8 commits September 21, 2018 13:03
@systeembeheerder
Update edgeos.rd to include device specs
85fb006 
example output:

# Version: v1.10.5
# Build ID: 5098915
# Build on: 06/22/18 13:57
# Copyright: 2012-2018 Ubiquiti Networks, Inc.
# HW model: EdgeRouter Infinity
# HW S/N: 788A20424090
#
@systeembeheerder
Merge pull request #1 from systeembeheerder/systeembeheerder-patch-mo…
6e6756a 
…deledgeos

Update edgeos.rd to include device specs
@laf
Update edgeos.rb
a11385e
@laf
Update edgeos.rb
ead3f2e
@systeembeheerder
add new model for LANCOM routers
666de39
@systeembeheerder
Merge branch 'master' of https://github.com/ytti/oxidized
7b8fa1b
@systeembeheerder
Merge remote-tracking branch 'origin/master' into lancom
a740357
@systeembeheerder
remove trailing space
eedd648
@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2020 •
edited
Loading

Codecov Report

Merging #2139 into master will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2139      +/-   ##
==========================================
+ Coverage   63.19%   63.32%   +0.13%     
==========================================
  Files          30       30              
  Lines        1497     1497              
==========================================
+ Hits          946      948       +2     
+ Misses        551      549       -2
Impacted Files Coverage Δ
lib/oxidized/output/git.rb 19.00% <0.00%> (+1.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a881bc...80031e6. Read the comment docs.

@wk
Copy link
Contributor

wk commented Jun 30, 2020

Hi!

Thanks for that, new models are always welcome. This PR will need an entry in CHANGELOG.md (documenting the change), and an entry in Supported-OS-Types.md (documenting the device support) before it can be pulled.

Finally, what is the reason for the model to be sending \r\n explicitly at the end of the command? Does simple invocation of cmd not do the right thing? Does it not do the right thing over both SSH and Telnet? This need is surprising as telnet sends \r\n at the end of a command by default, while ssh sends \n, so normally only an additional \r would be required to accomplish the same result.

@wk
Copy link
Contributor

wk commented Jul 6, 2020

Thanks for documenting this! Pulling it in.

@wk wk merged commit 650f2ff into ytti:master Jul 6, 2020
@systeembeheerder systeembeheerder deleted the lancom branch July 16, 2020 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@systeembeheerder @codecov-commenter @wk @laf