Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

routeros model: Remove intermittent POE comment #2141

Merged
merged 2 commits into from
Jun 30, 2020
Merged

Conversation

pioto
Copy link
Contributor

@pioto pioto commented Jun 25, 2020

Comments like this seem to come and go on some MikroTik equipment:

poe-out status: short_circuit

Pre-Request Checklist

  • Passes rubocop code analysis (try rubocop --auto-correct)
  • Tests added or adapted (try rake test)
  • Changes are reflected in the documentation
  • User-visible changes appended to CHANGELOG.md

Description

Comments like this seem to come and go on some MikroTik equipment:

# poe-out status: short_circuit
@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2020

Codecov Report

Merging #2141 into master will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2141      +/-   ##
==========================================
+ Coverage   63.19%   63.32%   +0.13%     
==========================================
  Files          30       30              
  Lines        1497     1497              
==========================================
+ Hits          946      948       +2     
+ Misses        551      549       -2     
Impacted Files Coverage Δ
lib/oxidized/output/git.rb 19.00% <0.00%> (+1.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a881bc...12b6e5f. Read the comment docs.

@wk wk merged commit f9f3e75 into ytti:master Jun 30, 2020
@wk
Copy link
Contributor

wk commented Jun 30, 2020

Thanks for this! I've added an attribution line to CHANGELOG.md for this change and pulled it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants