Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added aoscx.rb model #2163

Merged
merged 3 commits into from
Aug 16, 2020
Merged

Added aoscx.rb model #2163

merged 3 commits into from
Aug 16, 2020

Conversation

jmurphy5
Copy link
Contributor

@jmurphy5 jmurphy5 commented Jul 27, 2020

Pre-Request Checklist

  • Passes rubocop code analysis (try rubocop --auto-correct)
  • Tests added or adapted (try rake test)
  • Changes are reflected in the documentation
  • User-visible changes appended to CHANGELOG.md

Description

This adds a model for the Aruba CX switch line. It is modeled after the procurve module, with updated commands to match the Aruba AOS-CX software.

@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2020

Codecov Report

Merging #2163 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2163   +/-   ##
=======================================
  Coverage   63.32%   63.32%           
=======================================
  Files          30       30           
  Lines        1497     1497           
=======================================
  Hits          948      948           
  Misses        549      549           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48d8d87...e914a80. Read the comment docs.

@wk
Copy link
Contributor

wk commented Aug 15, 2020

Thanks for this! I notice this model is extremely similar to the procurve model. Is HP perhaps busy providing a unified NOS CLI experience for both procurve devices and these Aruba-CX devices? Could you perhaps provide the output of show version from such a device to understand what the difference may be?

If these devices and procurve devices indeed share a NOS/CLI, it would be preferred to maintain only one model and link the device to the correct model name, instead of introducing two parallel models which are largely similar.

@jmurphy5
Copy link
Contributor Author

They are similar, but there are enough commands that are different that I needed to . I know Aruba has two software sets, the AOS-CX and AOS-Switch. I believe AOS-Switch is the new version of the procurve software, but I will have to double check.

`-----------------------------------------------------------------------------
ArubaOS-CX
(c) Copyright 2017-2020 Hewlett Packard Enterprise Development LP

Version : FL.10.05.0001
Build Date : 2020-07-09 17:48:12 PDT
Build ID : ArubaOS-CX:FL.10.05.0001:53cb98af4936:202007092351
Build SHA : 53cb98af4936ce4b2e61fb4bb9dde7e7925c5e29
Active Image : primary

Service OS Version : FL.01.06.0004
BIOS Version : FL.01.0002`

@wk
Copy link
Contributor

wk commented Aug 16, 2020

If this is a unique variant of ArubaOS, then lets pull this in as a model! Thanks for contributing and the additional detail!

@wk wk merged commit 0e49c23 into ytti:master Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants