Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model/xos: filter perodic save schedule time #2169

Merged
merged 2 commits into from
Sep 8, 2020

Conversation

sargon
Copy link
Contributor

@sargon sargon commented Aug 6, 2020

Pre-Request Checklist

  • Passes rubocop code analysis (try rubocop --auto-correct)
  • Tests added or adapted (try rake test)
  • Changes are reflected in the documentation
  • User-visible changes appended to CHANGELOG.md

Description

Filter the next periodic schedule time from configuration output. In our case that line triggered a change several times a day.

@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2020

Codecov Report

Merging #2169 into master will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2169      +/-   ##
==========================================
- Coverage   63.32%   63.19%   -0.14%     
==========================================
  Files          30       30              
  Lines        1497     1497              
==========================================
- Hits          948      946       -2     
- Misses        549      551       +2     
Impacted Files Coverage Δ
lib/oxidized/output/git.rb 17.35% <0.00%> (-1.66%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e49c23...ef06abb. Read the comment docs.

@sargon sargon changed the title Enhance xos perodic save model/xos: filter perodic save schedule time Aug 6, 2020
@wk
Copy link
Contributor

wk commented Sep 8, 2020

Pulling this in, thanks!

@wk wk merged commit be01808 into ytti:master Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants