Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add git-email in dockerfile to allow git send-email from docker image #2193

Merged
merged 6 commits into from
Oct 6, 2020

Conversation

jmurphy5
Copy link
Contributor

@jmurphy5 jmurphy5 commented Oct 1, 2020

Pre-Request Checklist

  • Passes rubocop code analysis (try rubocop --auto-correct)
  • Tests added or adapted (try rake test)
  • Changes are reflected in the documentation
  • User-visible changes appended to CHANGELOG.md

Description

To enable git send-email while using the docker image, added git-email and libmailtools-perl to the Dockerfile. When the container is built it allows for sending git diffs via git send-email.

@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2020

Codecov Report

Merging #2193 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2193   +/-   ##
=======================================
  Coverage   63.32%   63.32%           
=======================================
  Files          30       30           
  Lines        1497     1497           
=======================================
  Hits          948      948           
  Misses        549      549           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be01808...6e72182. Read the comment docs.

@wk wk merged commit c0dae48 into ytti:master Oct 6, 2020
@wk
Copy link
Contributor

wk commented Oct 6, 2020

Thanks! Pulling this in since it's a small dependency in an (unfortunately) large container; please consider documenting this use case for those who prefer to use this method over the mail sending scripts in extra.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants