add bracket on node if using proxy and node has ipv6 address #2245
Conversation
opted to use "include" to validate if the ip address has the colon `:` string, instead of `ipaddress` gem
looks like `[ip]` works even with ipv4 address. so no need for an if statement. much simpler change
Codecov Report
@@ Coverage Diff @@
## master #2245 +/- ##
==========================================
- Coverage 63.30% 62.59% -0.72%
==========================================
Files 30 30
Lines 1496 1497 +1
==========================================
- Hits 947 937 -10
- Misses 549 560 +11
Continue to review full report at Codecov.
|
|
find it strange that Travis complains when the change is soo minor.... I think other projects on github were having travis issues recently.... |
|
Sorry for the bump... Just wanted to bring to the attention, since this change is literally the addition of two characters 😄 Happy Friday!! |
|
Apologies and thank you. |
|
@ytti have a good weekend |
Should solve: #2228
Note:
Not a ruby dev so i am sure there is a better way to do it.
Open to suggestions.
I also tested if node has an ipv4 address and it also works. So basically, at least from what i can tell, it does not break anything. 😆
Thanks,
Dave