Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix when auto-saved is configured on xos switches #2321

Merged
3 commits merged into from
Dec 20, 2021
Merged

Conversation

trappiz
Copy link
Contributor

@trappiz trappiz commented Jun 14, 2021

Pre-Request Checklist

  • Passes rubocop code analysis (try rubocop --auto-correct)
  • Tests added or adapted (try rake test)
  • Changes are reflected in the documentation
  • User-visible changes appended to CHANGELOG.md

Description

Had issues that new backups where pushed every hour to git when "Next periodic save on" was updated with the next time to run.
Instead set the row to "empty".

 #  primary.cfg       Created by ExtremeXOS version 30.7.1.1
 #                    542681 bytes saved on Fri May 28 09:09:10 2021
 #                   Auto-saved every 60 minutes, if configuration is changed.
- #                   Next periodic save on Mon Jun 14 11:57:27 2021
+ #                   

Had issues that new backups where pushed every hour to git when "Next periodic save on" was updated with the next time to run.
Instead set the row to "empty".

  # primary.cfg       Created by ExtremeXOS version 30.7.1.1
  #                   542681 bytes saved on Fri May 28 09:09:10 2021
  #                   Auto-saved every 60 minutes, if configuration is changed.
-  #                   Next periodic save on Mon Jun 14 11:57:27 2021
+ #                   
  #
@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2021

Codecov Report

Merging #2321 (7352c30) into master (a02074a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2321   +/-   ##
=======================================
  Coverage   63.28%   63.28%           
=======================================
  Files          30       30           
  Lines        1498     1498           
=======================================
  Hits          948      948           
  Misses        550      550           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a02074a...7352c30. Read the comment docs.

@athompson-merlin
Copy link

FWIW, it would be really nice to get this merged - I've had to turn off auto-save on all my XOS switches to avoid needless config churn with Oxidized.

@ghost
Copy link

ghost commented Nov 30, 2021

Can you please update the changelog?

@trappiz
Copy link
Contributor Author

trappiz commented Dec 17, 2021

Can you please update the changelog?

Updated the changelog now :)

@ghost ghost merged commit af6f072 into ytti:master Dec 20, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants