Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes ArubaOS-CX enviroment/system inconsistent values #2297 #2372

Merged
7 commits merged into from
Dec 1, 2021

Conversation

raunz
Copy link
Contributor

@raunz raunz commented Sep 29, 2021

Pre-Request Checklist

  • Passes rubocop code analysis (try rubocop --auto-correct)
  • Changes are reflected in the documentation
  • User-visible changes appended to CHANGELOG.md

Description

Removed always changing Up Time/CPU/Memory lines from 'show system' with command enchancement.
Replaced temperature and fan RPM values with string avoid minor changes but to keep the model/component technical information.

Closes issue #2297

@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2021

Codecov Report

Merging #2372 (fedc30f) into master (4ed0fd7) will decrease coverage by 0.13%.
The diff coverage is n/a.

❗ Current head fedc30f differs from pull request most recent head 8b0934b. Consider uploading reports for the commit 8b0934b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2372      +/-   ##
==========================================
- Coverage   62.59%   62.45%   -0.14%     
==========================================
  Files          30       30              
  Lines        1497     1497              
==========================================
- Hits          937      935       -2     
- Misses        560      562       +2     
Impacted Files Coverage Δ
lib/oxidized/output/git.rb 17.35% <0.00%> (-1.66%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1c97dd...8b0934b. Read the comment docs.

@danpoltawski
Copy link
Contributor

Could you rebase this :)

@jmurphy5
Copy link
Contributor

jmurphy5 commented Oct 6, 2021

I put in #2379 to remove the show environment fully. The Uptime, CPU, and Memory filter are a great catch @raunz !

@ghost
Copy link

ghost commented Dec 1, 2021

Can you please resolve the conflict?

@raunz
Copy link
Contributor Author

raunz commented Dec 1, 2021

Can you please resolve the conflict?
Done.

@ghost ghost merged commit 3e06db1 into ytti:master Dec 1, 2021
@raunz raunz deleted the issue-2297 branch December 1, 2021 07:56
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants