Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generic FortiOS model to support new fortigate version and VM based products #2373

Merged
7 commits merged into from
Dec 29, 2021

Conversation

raunz
Copy link
Contributor

@raunz raunz commented Sep 29, 2021

Pre-Request Checklist

  • Passes rubocop code analysis (try rubocop --auto-correct)
  • Changes are reflected in the documentation
  • User-visible changes appended to CHANGELOG.md

Description

Closes issue #2227 by extending regex for clustered enviroment.
Introduces trial-and-error style for the new Fortigate VM based environments: FortiManager, FortiAnalyzer, FortiMail. The first succeeding command output will be appended to cfg.
Due to a bunch of new output variations in "get system status" the regex lines have multiple additions to keep the cfg stable. Similar regex improvements proposed in #2180 are also included in this PR.

Includes the same removal of "AV AI/ML Model" from "get system status" command as in pull request #2328

PS. FortiMail is the only FortiGate product which SSH daemon requires keyboard-interactive auth method in Oxidized config, all the other fortios devices are happy with auth_method "password".

@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2021

Codecov Report

Merging #2373 (80b8632) into master (8179f48) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2373   +/-   ##
=======================================
  Coverage   62.59%   62.59%           
=======================================
  Files          30       30           
  Lines        1497     1497           
=======================================
  Hits          937      937           
  Misses        560      560           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8179f48...80b8632. Read the comment docs.

@ghost ghost merged commit c161a26 into ytti:master Dec 29, 2021
@ghost ghost mentioned this pull request Jan 3, 2022
4 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants