Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPNsense/PFsense models: Do not remove <?xml header, and add version information as comment. #2377

Merged
5 commits merged into from
Jan 10, 2022

Conversation

pv2b
Copy link
Contributor

@pv2b pv2b commented Sep 30, 2021

Pre-Request Checklist

  • Passes rubocop code analysis (try rubocop --auto-correct)
  • Tests added or adapted (try rake test)
  • Changes are reflected in the documentation
  • User-visible changes appended to CHANGELOG.md

Description

This PR does a two things:

  1. There was an issue where the OPNsense and PFsense models would chop off the first line of the config file containing an <?xml... header. This is unneccessary and might cause issues, and was probably left in unintentionally, so I removed this.
  2. Added functionality to OPNsense and PFsense models to gather version information and put it into a comment.
  3. Refactors the "xmlcomment" function added in step 2 into model.rb, since it's probably useful to other models, and it's really messy to keep it in the opnsense and pfsense models.

This model was mistakenly removing the first line of the config file containing the <?xml line.
@ghost
Copy link

ghost commented Dec 29, 2021

Can you add the change to changelog please?

@ghost ghost mentioned this pull request Dec 29, 2021
4 tasks
@pv2b
Copy link
Contributor Author

pv2b commented Jan 10, 2022

Can you add the change to changelog please?

Done

@ghost ghost merged commit 00c1394 into ytti:master Jan 10, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant