routeros: /export params depending on version

[azielke]

Pre-Request Checklist

• Passes rubocop code analysis (try rubocop --auto-correct)
• Tests added or adapted (try rake test)
• Changes are reflected in the documentation
• User-visible changes appended to CHANGELOG.md

Description

Fix Mikrotik Routeros Backups being empty for routeros versions <7.

Closes issue #2427

[jplitza]

Tested successfully (without :remove_secrets) on ROS 6.48.6 and ROS 7.1.

@azielke Could you please fix the RuboCop styling warnings?

[codecov-commenter]

Codecov Report

Merging #2435 (23466e3) into master (879d489) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2435      +/-   ##
==========================================
+ Coverage   63.25%   63.28%   +0.02%     
==========================================
  Files          30       30              
  Lines        1497     1498       +1     
==========================================
+ Hits          947      948       +1     
  Misses        550      550              

Impacted Files	Coverage Δ
lib/oxidized/node.rb	70.83% <0.00%> (+0.20%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 879d489...23466e3. Read the comment docs.

[jplitza]

Out of curiosity, what happens then no line matches installed-version? I have no clue about Ruby, but I guess that @ros_version = nil and @ros_version >= 7 throws a NoMethodError? Maybe the conditional should cover that case:

if not @ros_version.nil? and @ros_version >= 7

[azielke]

installed-version should always be present - but it would indeed throw NoMethodError (which would show an error when fetching the config). I think doing the check for nil would indeed be best as this would behave exactly the same as it did previously.

[jplitza]

LGTM.

Since there's not mention of the newly added ROS 7 support in the changelog yet, it doesn't really seem mandatory to add an entry for this change - but the ROS 7 support should be added. Maybe a maintainer can do that outside of this PR