Fix TrueNAS locking contention #2653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s, which are tougher to square away inside the docker container: ``` I, [2022-11-08T16:00:47.176135 ytti#1] INFO -- : Oxidized starting, running as pid 1 I, [2022-11-08T16:00:47.183041 ytti#1] INFO -- : lib/oxidized/nodes.rb: Loading nodes I, [2022-11-08T16:00:47.780358 ytti#1] INFO -- : lib/oxidized/nodes.rb: Loaded 13 nodes Puma starting in single mode... * Version 3.11.4 (ruby 2.7.0-p0), codename: Love Song * Min threads: 0, max threads: 16 * Environment: development * Listening on tcp://0.0.0.0:8888 Use Ctrl-C to stop F, [2022-11-08T16:00:55.490046 ytti#1] FATAL -- : Oxidized crashed, crashfile written in /root/.config/oxidized/crash config value 'safe.directory' was not found ``` I'm not sure this is the "right" fix, because I think that maybe the _real_ answer is to make sure the permissions for the git repo inside the container are set correctly so that `safe.directory` configurations aren't necessary.
…rueNAS Occasionally, without this, the resulting output would be: ``` /**** ERROR: (5) database is locked *****/ ROLLBACK; -- due to errors ``` This should allow the command to run even if the database is locked.
|
Please add your changes to CHANGELOG.md |
ghost
merged commit 
4 tasks
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Request Checklist
rubocop --auto-correct)rake test)Description
There's an occasional race condition in the TrueNAS module. When the TrueNAS software is accessing the SQLite database, the command to dump it will fail and output only:
This command invocation ought to get it to open even if it's locked, with the promise of being a read-only session.