Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Request Checklist
rubocop --auto-correct
)- [ ] Tests added or adapted (tryrake test
)- [ ] Changes are reflected in the documentation- [ ] User-visible changes appended to CHANGELOG.mdDescription
Fixes a bug caused by the RuboCop autocorrect.
In /lib/oxidized/output/git.rb the code in line 82 caused an error.
Cause is
next if commit.diff(paths: [path]).empty?
, the return value of diff has noempty?
function.The old line
next if commit.diff(paths: [path]).empty?
was correct.The same mistake was corrected in this commit back in 2019.
This time i also disabled the RuboCop check for this line so that autocorrect doesn't change this again.
Possibly this also solves issues 2715 and 2282 because the error when clicking the "Version" button led me to this bug. And this bugfix solved it for me.