Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Netscaler with hostname backups #2828

Merged
3 commits merged into from
Jul 4, 2023
Merged

Conversation

electrocret
Copy link
Contributor

@electrocret electrocret commented Jun 13, 2023

Currently Netscalers with "set ns hostName name" set aren't able to be backed up cause Oxidized doesn't recognize a valid prompt.

Prompt when not set:
>

Prompt when set:
username@hostname>

Current regex isn't liking the change.

I'm sure there's a more graceful way of dealing with the change, but I'm not good with regex. This works for me.

Pre-Request Checklist

  • Passes rubocop code analysis (try rubocop --auto-correct)
  • Tests added or adapted (try rake test)
  • Changes are reflected in the documentation
  • User-visible changes appended to CHANGELOG.md

Description

@ghost
Copy link

ghost commented Jun 19, 2023

can you please fix the conflict (sorry)

@electrocret
Copy link
Contributor Author

Done

@ghost ghost merged commit a3cf83c into ytti:master Jul 4, 2023
@electrocret electrocret deleted the Fix-Named-Netscalers branch July 19, 2023 02:12
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant