Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update iosxr.rb with admin keyword for show inventory command #2915

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

maugli13
Copy link
Contributor

Pre-Request Checklist

  • [] Passes rubocop code analysis (try rubocop --auto-correct)
    The core code didn't change. Only specific model
  • Tests added or adapted (try rake test)
    The core code didn't change. Only specific model
  • Changes are reflected in the documentation
    Particular Model didn't have the documentation
  • User-visible changes appended to CHANGELOG.md
    N/A

Description

"show inventory" command without admin keyword is not showing some useful inventory information, such as FAN, PSU and Chassis serial and part numbers

"show inventory" command without admin keyword is not showing some useful inventory information, such as FAN, PSU and Chassis serial and part numbers
@github-actions github-actions bot added the Stale label Oct 21, 2023
@github-actions github-actions bot closed this Oct 29, 2023
@aschaber1
Copy link
Collaborator

Does it show nothing or just less information?
Does admin need elevated privileges?

@aschaber1 aschaber1 reopened this Oct 30, 2023
@maugli13
Copy link
Contributor Author

@aschaber1 without admin command "show inventory" providing less information.
For example, FAN, PSUs, and Chassis related data are absent.

Yes, admin mode requires root-system group access privileges; commands executed by the elevated users can be limited to RO by AAA or any other options.

@github-actions github-actions bot removed the Stale label Oct 31, 2023
@github-actions github-actions bot added the Stale label Dec 31, 2023
@robertcheramy robertcheramy self-assigned this Jan 16, 2024
@robertcheramy
Copy link
Collaborator

As "show running-config" already needs elevated privileges, I think "admin show inventory" should be OK.

@robertcheramy robertcheramy merged commit 5d1475b into ytti:master Jan 16, 2024
2 of 5 checks passed
@maugli13 maugli13 deleted the extending_iosxr_model branch January 17, 2024 22:54
packettoobig added a commit to packettoobig/oxidized that referenced this pull request Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants