Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1699 by not including all default values (with show full-confi… #2935

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

jforeman
Copy link
Contributor

…guration). Fixes the invariable timeout in my setup.

Description

Shows the config instead of full config which contains extraneous amounts of default data and causes timeouts.

Closes issue #1699

@aschaber1 aschaber1 self-assigned this Oct 30, 2023
@robertcheramy
Copy link
Collaborator

@jforeman - could you add the change in the CHANGELOG.md? As we change the behaviour of the model, our users should know it ;-)

@jforeman
Copy link
Contributor Author

@robertcheramy done, but looks like I somehow created a conflict.

jforemanadmin and others added 2 commits December 4, 2023 14:44
@aschaber1
Copy link
Collaborator

@ytti, this is kind of a breaking change, it will halve the output (even though the missing output is default config for fortigate). Any thoughts on how to proceed on this?

@jforeman
Copy link
Contributor Author

jforeman commented Dec 4, 2023

@aschaber1, @ytti If this change is a concern, I'd be open to working with you to troubleshoot why the full-configuration output is breaking, but it's definitely not just happening to me. Thanks!

@robertcheramy
Copy link
Collaborator

robertcheramy commented Dec 11, 2023

The way to backup config as in this PR is the expected behavior. It backups the configutation the same way as you would get it from the GUI.
As an example. the configuration for "port1" before the PR:

config system interface
    edit "port1"
        set vdom "root"
        set vrf 0
        set fortilink disable
        set mode static
        set dhcp-relay-interface-select-method auto
        set dhcp-relay-service disable
        set ip 192.168.129.8 255.255.255.0
        set allowaccess ping https ssh http fgfm
        set fail-detect disable
        set pptp-client disable
        set arpforward enable
        set broadcast-forward disable
        set bfd global
        set l2forward disable
        set icmp-send-redirect enable
        set icmp-accept-redirect enable
        set reachable-time 30000
        set vlanforward disable
        set stpforward disable
        set ips-sniffer-mode disable
        set ident-accept disable
        set ipmac disable
        set subst disable
(...)

And the same Configuration after the PR (and also when doing a configuration backup through GUI):

config system interface
    edit "port1"
        set vdom "root"
        set ip 192.168.129.8 255.255.255.0
        set allowaccess ping https ssh http fgfm
        set type physical
        set snmp-index 1
    next

This is a good PR, I tested it and I recommend a merge.

@robertcheramy robertcheramy merged commit 3a703d0 into ytti:master Jan 15, 2024
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants