Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comware.rb login/password regex #2970

Merged
merged 4 commits into from
Jan 22, 2024

Conversation

sharteeya
Copy link
Contributor

Pre-Request Checklist

  • Passes rubocop code analysis (try rubocop --auto-correct)
  • Tests added or adapted (try rake test)
  • Changes are reflected in the documentation
  • User-visible changes appended to CHANGELOG.md

Description

Changes:

  1. Adjust login regex in comware.rb. So uppercase login prompt will be match.
  2. Replace the white space with \s? when command super in comware.rb. Since some of the devices does not have that white space, the original regex will cause not matching issue.

@aschaber1
Copy link
Collaborator

Hello @sharteeya, thank you for contributing. Could you please add a line to the changelog?

@sharteeya
Copy link
Contributor Author

@aschaber1 I've add changes into changelog. Thanks for helping!

@github-actions github-actions bot added the Stale label Dec 31, 2023
@robertcheramy robertcheramy merged commit 469668f into ytti:master Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants