Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model vyatta: hide wireguard private-key and preshared-key #3099

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

gauthierl
Copy link

Pre-Request Checklist

  • Passes rubocop code analysis (try rubocop --auto-correct)
  • Tests added or adapted (try rake test)
  • Changes are reflected in the documentation
  • User-visible changes appended to CHANGELOG.md

Description

The patch hide secrets of WireGuard interfaces in vyatta / vyos :

I was not able to try Rubocop and rake test. I'm not used to these tools and didn't manage to use them.

I tried this patch on our instance of Oxidized and the patch produce this change on VyOS 1.5 :

-set interfaces wireguard wg0 peer mypeer preshared-key 'DFpH6vrTlXczS/eHFUt+rddmE7zRaeQ1oCiprVGwzXs='
+set interfaces wireguard wg0 peer mypeer preshared-key <secret removed>
set interfaces wireguard wg0 peer mypeer public-key 'qu3a1Dus/jaE4QM6qIUWaF/Jdktg8+FyMssicDMsu1Y='
set interfaces wireguard wg0 port '43521'
-set interfaces wireguard wg0 private-key 'SCcDxY9eldGfQKlncqtPifGw0JHtedszS89V5BpTQWM='
+set interfaces wireguard wg0 private-key <secret removed>

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.49%. Comparing base (6e27165) to head (526f3a8).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3099   +/-   ##
=======================================
  Coverage   65.49%   65.49%           
=======================================
  Files          34       34           
  Lines        1649     1649           
=======================================
  Hits         1080     1080           
  Misses        569      569           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robertcheramy
Copy link
Collaborator

Thank you for your PR. It has passed Rubocup, cheers :-)

For next PR:

@robertcheramy robertcheramy merged commit dee06bb into ytti:master Mar 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants