Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vyatta/vyos: update prompt matcher to account for non-privileged users #3112

Merged
merged 5 commits into from
Apr 15, 2024

Conversation

h-lopez
Copy link
Contributor

@h-lopez h-lopez commented Mar 25, 2024

Pre-Request Checklist

  • Passes rubocop code analysis (try rubocop --auto-correct)
  • Tests added or adapted (try rake test)
  • Changes are reflected in the documentation
  • User-visible changes appended to CHANGELOG.md

Description

matches prompt ending with '>' which corresponds to non-privileged accounts.
allows oxidized to use a non or low-privileged account to login to a VyOS device.
see related issue for detail

Closes issue #3111

@h-lopez h-lopez changed the title Vyos priv level prompt fix vyatta/vyos: update prompt matcher to account for non-privileged users Mar 25, 2024
Copy link
Collaborator

@robertcheramy robertcheramy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. Please have a look on the comments.

lib/oxidized/model/vyatta.rb Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@h-lopez
Copy link
Contributor Author

h-lopez commented Apr 12, 2024

I've made the requested changes, please review when you have a chance. Thanks!

@robertcheramy robertcheramy merged commit 2bfd3f2 into ytti:master Apr 15, 2024
5 checks passed
@robertcheramy
Copy link
Collaborator

Close #3111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants