Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix arubaOS-CX power-consumption changes logged #3143

Merged
merged 5 commits into from
May 17, 2024

Conversation

TerraTalpi
Copy link
Contributor

@TerraTalpi TerraTalpi commented Apr 29, 2024

Pre-Request Checklist

Description

Fix #3142. The ArubaOS-CX switches with the new Long Support Release (LSR) Version FL.10.13.xxxx introduce a new sub-command show environment power-consumption. This displays current power consumption values for all switches in the stack. This is a fix, to exclude all actual power consumption values from the output.

Exclude actual power consumption from output. Command "show environment power-consumption" has been introduced with ArubaOS-CX Long Support Release (LSR) version FL.10.13.xxx. This was not included in the previous LSR FL.10.10.xxx. Related issue is ytti#3142. Based on the work of @danpoltawski
Exclude actual power consumption from output. Command "show environment power-consumption" has been introduced with ArubaOS-CX Long Support Release (LSR) version FL.10.13.xxx. This was not included in the previous LSR FL.10.10.xxx. Related issue is ytti#3142. Based on the work of @danpoltawski
@alextremblay
Copy link

Hi @TerraTalpi , I tested out the changes in your PR, and i found that the changes DO work, but leave soemthing to be desired...

it will still produce a "change" if any of the power numbers changes from 2 digits to 3 digits (ie if from one oxidixed run to another, instantaneous power goes from "99.50" to "103.50", then the output after that PR will go from this to this:

#    6300M 48SR5 CL6 PoE 4SFP56 Swc      <power>    <power>
#    6300M 48SR5 CL6 PoE 4SFP56 Swc      <power>     <power>

also, it doesn't capture or strip total power consumption, so any changes there will still be captured

TerraTalpi added 2 commits May 3, 2024 11:26
fixes power consumptipon for up to a for digit number and keep table formatting. Starting with ArubaOS-CX Version FL.10.13.xxx
@TerraTalpi
Copy link
Contributor Author

Dear maintainers, ready to merge from my side, I have vastly expanded support for multiple arubaOS-CX switch series and chassis switches. For details, see related issue with the deeper analysis of the outputs that may come and must be parsed.

@robertcheramy
Copy link
Collaborator

@alextremblay - does the PR now works for you?

@robertcheramy robertcheramy added this to the 0.31 milestone May 13, 2024
remove trailing white spaces of line "# match Total Power consumption:"
@TerraTalpi
Copy link
Contributor Author

Hi @robertcheramy thank you for approving the CI/CD runs. I have corrected the trailing whitespaces error, sorry for that. Please run the tests again in order for all tests to pass.

@robertcheramy
Copy link
Collaborator

@alextremblay - I will merge this PR. If you miss something, this can be changed / added afterwards.

@robertcheramy robertcheramy merged commit 4b0b655 into ytti:master May 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HP ArubaOS-CX: power-consumption starting with version FL.10.13.xxxx - permanent power changes logged
3 participants