-
Notifications
You must be signed in to change notification settings - Fork 931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uplink_olt_model_add #3231
uplink_olt_model_add #3231
Conversation
Please document your change in CHANGELOG.md and add the model in docs/Supported-OS-Types.md The code must pass |
Finally made time to do the test and updated the files today. Let me know if everything is fine or not. |
@AAm-kun you should ask @robertcheramy to review, not me. I find i hard to find any information on the vendor 'uplink' and 'EP4440' seems a specific device, not an network OS. Is OLT the OS then? But yet you add EP4440 to the OS list. Just my two cents. |
@systeembeheerder Well Uplink is a rebrand of VSOL if I am not wrong. The OS is same, at least what I saw the webui in youtube videos. @robertcheramy please review when you have time. |
The PR looks good, I will be happy to merge it into master after following changes:
|
Update - consider the unit test point as optional - making the yaml file is to complicated yet, I must improve the documentation before asking submitter do to so. |
change-log has been added. Let me know if anything else is missing. |
- Author of the model in CHANGELOG.md - Supported OS Types in alphabetical order
Sorry for the long delay - I was busy with other topics. |
Description
Added UPLINK olt support. V-SOL olt also might work as uplink is rebrand of v-sol in some way. not tested on V-SOL though.
Some part of the code was taken from https://gist.github.com/mdpuma/0df4bc4fe6dd8d0aad6d0445902a9f63 and some was generated by Mistral AI.
P:S: Not a ruby dev, just a network engineer who was able to make it work and wanted to share with the community.