Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cumulus: Add nvue support #3246

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Conversation

Lagertonne
Copy link
Contributor

Pre-Request Checklist

  • Passes rubocop code analysis (try rubocop --auto-correct)
  • Changes are reflected in the documentation
  • User-visible changes appended to CHANGELOG.md

Description

With Cumulus 4.4, Nvidia has introduced the "Nvidia User Experience" (nvue) into Cumulus, which is another way to configure a Cumulus device.
This Pull-Request adds the possiblity to fetch the current configuration of the device in the YAML-format.

@Lagertonne Lagertonne force-pushed the feature/cumulus_nvue branch from 76b984d to c7b3b1e Compare August 13, 2024 06:10
@robertcheramy
Copy link
Collaborator

Thank you for your contribution.

Please provide a unit test for the model. You will need to rebase / merge from master in order to use model_helper.rb in the unit test.

@robertcheramy
Copy link
Collaborator

Update - making the yaml file is to complicated yet, I must improve the documentation before asking submitter do to so.
=> Merging into master

@robertcheramy robertcheramy merged commit 2ef5be1 into ytti:master Sep 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants