Ssh key support

[awlx]

Adds the functionality to provide a ssh public and privatekey to use for SSH GIT connect.

[danilopopeye]

@awlx no tests for this? 😢

[awlx]

Sorry, was a quick fix to get it finally working. Tests will follow when I have time.

And tbh. First time I use ruby, no clue how this tests work ;).

[danilopopeye]

@awlx I haven't test this, but it should be close 😉

-      it "will push to the remote repository using ssh" do
-        Oxidized.config.hooks.github_repo_hook.remote_repo = 'git@github.com:username/foo.git'
-        Rugged::Credentials::SshKeyFromAgent.expects(:new).with(username: 'git').returns(credentials)
-        gr.cfg = Oxidized.config.hooks.github_repo_hook
-        gr.run_hook(ctx).must_equal true
+      describe "will push to the remote repository using ssh" do
+        before do
+          Oxidized.config.hooks.github_repo_hook.remote_repo = 'git@github.com:username/foo.git'
+          Oxidized.config.hooks.github_repo_hook.pubkey = 'pubkey'
+          Oxidized.config.hooks.github_repo_hook.privkey = 'privkey'
+        end
+
+        it "using credentials" do
+          Rugged::Credentials::SshKeyFromAgent.expects(:new).with(username: 'git').returns(credentials)
+          gr.cfg = Oxidized.config.hooks.github_repo_hook
+          gr.run_hook(ctx).must_equal true
+        end
+
+        it "using public and private keys" do
+          File.expects(:expand_path).with('pubkey').returns('/pubkey')
+          File.expects(:expand_path).with('privkey').returns('/privkey')
+
+          Rugged::Credentials::SshKey.expects(:new).with(username: 'git', publickey: '/pubkey', privatekey: '/privkey').returns(credentials)
+          gr.cfg = Oxidized.config.hooks.github_repo_hook
+          gr.run_hook(ctx).must_equal true
+        end

[danilopopeye]

@awlx another thing, what do you think of using the same keys that Rugged use: publickey and privatekey ?

/cc @ytti + @ElvinEfendi

[awlx]

Feel free, also thought about it. But I am lazy and so short config options are better ;).

[ytti]

@danilopopeye publickey and privatekey are probably more descriptive yes.

[awlx]

Fixed the variable names.

[danilopopeye]

@awlx let me know if you have problem with the tests 😃

[awlx]

@danilopopeye how do I test if they work the way I expect them to ? :D

[danilopopeye]

@awlx the other comment I've made, already does this.

it "using public and private keys" do
  # this line here
  Rugged::Credentials::SshKey.expects(:new).with(username: 'git', publickey: '/pubkey', privatekey: '/privkey').returns(credentials)
  gr.cfg = Oxidized.config.hooks.github_repo_hook
  gr.run_hook(ctx).must_equal true
end

The line I marked, tests the class Rugged::Credentials::SshKey must received a call to #new with the hash:
{ username: 'git', publickey: '/pubkey', privatekey: '/privkey' }.

Have I made sense?

[awlx]

Yeah, that makes sense. My question was more "how do I test the test?".

[danilopopeye]

Oh, sorry! Must have needing more ☕! That diff is for the spec/githubhook_spec.rb file, it should be around line 115.

After that, just run rake test in the console.

[ElvinEfendi]

@awlx another thing, what do you think of using the same keys that Rugged use: publickey and privatekey ?

👍 I also think we should keep it consistent with Rugged's keys.

[awlx]

It's already renamed and merged :). Tests will follow soon.

THX for the feedback!