Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 6 #8

Merged
merged 5 commits into from
Oct 1, 2020
Merged

Issue 6 #8

merged 5 commits into from
Oct 1, 2020

Conversation

rogercyyu
Copy link
Contributor

Hi, sorry for the old closed PR, just wanted to ensure no major bugs.

I added the Wayback machine feature to your code.
This fixes issue 6. Additionally I used a new package called Newtonsoft.Json to parse the Json object. I tried not to touch the formatting, however I recommend removing all the extra line spaces and maybe do some formatting, since it is kind of hard to read currently.

Let me know what you think, thanks!

@yuanLeeMidori yuanLeeMidori merged commit 8d0999f into yuanLeeMidori:master Oct 1, 2020
@yuanLeeMidori
Copy link
Owner

No worries. Thank you for your contribution. The Wayback feature is great!

And thanks for the suggestion of formatting. I'll keep that in mind and make improvements.

Thanks again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants