Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reactify moved from devDeps to deps #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tajo
Copy link

@tajo tajo commented Apr 15, 2015

Reactify must be in normal deps, otherwise it doesn't work properly if your project build process is different (for example, I'm using babelify transformation instead of reactify).

Error : Cannot find module 'reactify' from '/Project/node_modules/halogen'

We already discussed that in #1 and you put it back. The other solution is to point package's main to bundled version.

@tajo
Copy link
Author

tajo commented Apr 16, 2015

Oh, it was already solved here: #8 and it came back. :-)

@yuanyan
Copy link
Owner

yuanyan commented May 4, 2015

@tajo It is javascript source now when you install from npm, still need config reactify to dependencies?

@tajo
Copy link
Author

tajo commented May 9, 2015

Yep, I do. The problem is caused by:

  "browserify": {
    "transform": [
      "reactify"
    ]
  },
  "browserify-shim": {
    "react": "global:React"
  },

When I delete it, it works.

@ascrazy
Copy link

ascrazy commented Jun 30, 2015

This problem still actual. Maybe it will be better to remove browserify config from package.json and specify transforms in gulpfile directly?

@ascrazy
Copy link

ascrazy commented Jun 30, 2015

Oh, I saw that transforms already specified in gulpfile.js, so I believe it is no longer needed in package.json.

@SebT
Copy link

SebT commented Sep 4, 2015

+1

@iandoe
Copy link

iandoe commented Oct 19, 2015

Hey, i am still getting this error, using react 0.14 and halogen 0.1.10. Any pointers ?

@tajo
Copy link
Author

tajo commented Oct 19, 2015

Well, reactify is based on react-tools which were deprecated since June and are completely removed in React 0.14.0. The official JSX transformer is Babel now. So this lib is broken. You can fork it if @yuanyan will not fix it or just copy&paste needed parts (my solution since all I really needed was just one loader).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants