Merge pull request #2 from wanglam/fix-dqc-selection

Fix modal dqc selection
yubonluo · Aug 28, 2024 · 49377ce · 49377ce
2 parents 20db731 + 4f6d8d9
commit 49377ce
Showing 1 changed file with 3 additions and 8 deletions.
diff --git a/src/plugins/workspace/public/components/workspace_detail/association_data_source_modal.tsx b/src/plugins/workspace/public/components/workspace_detail/association_data_source_modal.tsx
@@ -163,14 +163,9 @@ export const AssociationDataSourceModal = ({
               );
               const isParentCheckedThisTime = newCheckedConnectionIds.includes(parentConnection.id);
 
-              // Parent change to checked this time
-              if (!isParentCheckedLastTime && isParentCheckedThisTime) {
-                option.checked = 'on';
-              }
-
-              // This won't be executed since checked options already been filter out
-              if (isParentCheckedLastTime && isParentCheckedThisTime) {
-                option.checked = undefined;
+              // Update checked status if parent checked status changed this time
+              if (isParentCheckedLastTime !== isParentCheckedThisTime) {
+                option.checked = isParentCheckedThisTime ? 'on' : undefined;
               }
             }
           }