Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to build fixes branch due to usage of incomplete type #1

Open
selalipop opened this issue Jun 28, 2021 · 0 comments
Open

Unable to build fixes branch due to usage of incomplete type #1

selalipop opened this issue Jun 28, 2021 · 0 comments

Comments

@selalipop
Copy link

selalipop commented Jun 28, 2021

In AsyncWebSocket.h there is a forward declaration of AsyncWebSocketControl. Later in the header this declaration is referenced in defining AsyncWebSocketClient:

    class AsyncWebSocketControl; //Defined in AsyncWebSocket.cpp

    ...


    class AsyncWebSocketClient{
        std::deque<AsyncWebSocketControl> _controlQueue; 
        ...
    }

However, as far as I can tell std::deque requires a complete type definition, leading to this error:

error: invalid use of incomplete type 'std::deque<AsyncWebSocketControl>

I know C++17 allows certain containers to use incomplete types in declarations, but as far as I could find, std::deque is not one of them, I believe this branch is trying to limit itself to C++11 features

Has anyone else ran into this? A quick fix is to move the full declaration of AsyncWebSocketControl to the header file, but there are many commits after the commit that introduced the usage std::deque, some I'm wondering if it could be something with my environment or imports

Full logs, but it's mostly repeating the same error

tweidelt pushed a commit to tweidelt/ESPAsyncWebServer that referenced this issue Aug 13, 2023
Manual merge from anton-zolotarev:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant