Fix capture names for label

[yitzchak]

\label parameter should probably be something like constant.other.reference.latex not variable.parameter.definition.latex

Current naming prevents correct highlighting, etc.

[yudai-nkt]

Thanks for opening the PR @yitzchak!

It seems good, so I merged. However, could you mind telling me what you meant by "etc."? I couldn't come up with problems other than the argument of \label.

[yitzchak]

I changed keyword.control.latex to keyword.control.label.latex mostly
for consistency with the other reference commands.

Changing variable.parameter.definition.latex to
constant.other.reference.latex is the main issue for me. First, using
variable.parameter.definition.latex causes incorrect highlighting.
Second, my package linter-spell and linter-spell-latex use grammar scopes
to determine what text ranges to include or exclude from spell checking. I
cannot reasonably exclude a region scoped with
variable.parameter.definition.latex but can exclude a region marked
constant.other.reference.latex since this is clearly a label which should
not be spell checked.

Hope that makes sense.

On Sat, Jul 16, 2016 at 12:42 PM, Yudai NAKATA notifications@github.com
wrote:

Thanks for opening the PR @yitzchak https://github.com/yitzchak!

It seems good, so I merged. However, could you mind telling me what you
meant by "etc."? I couldn't come up with problems other than the argument
of \label.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABMK2WktbWIyClPdUFr6EKt9vPEPCgGeks5qWQnugaJpZM4JOChA
.