Skip to content

Commit

Permalink
[stable/spring-cloud-data-flow] Update configs for additional vars (h…
Browse files Browse the repository at this point in the history
…elm#17050)

- add support for service labels/annotations, env var for cert trusting

Signed-off-by: Chris Schaefer <cschaefer@pivotal.io>
  • Loading branch information
chrisjs authored and Ram Sri committed Sep 30, 2019
1 parent 0ed1de5 commit 8dc3a49
Show file tree
Hide file tree
Showing 7 changed files with 26 additions and 3 deletions.
2 changes: 1 addition & 1 deletion stable/spring-cloud-data-flow/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v1
description: Toolkit for building data processing pipelines.
name: spring-cloud-data-flow
version: 2.4.2
version: 2.4.3
appVersion: 2.2.1.RELEASE
home: http://cloud.spring.io/spring-cloud-dataflow/
sources:
Expand Down
9 changes: 7 additions & 2 deletions stable/spring-cloud-data-flow/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -81,10 +81,12 @@ The following tables list the configurable parameters and their default values.
| server.version | The version/tag of the Data Flow server | 2.2.1.RELEASE
| server.imagePullPolicy | The imagePullPolicy of the Data Flow server | IfNotPresent
| server.service.type | The service type for the Data Flow server | LoadBalancer
| server.service.annotations | Extra annotations for service resources | {}
| server.platformName | The name of the configured platform account | default
| server.service.annotations | Extra annotations for service resource | {}
| server.service.externalPort | The external port for the Data Flow server | 80
| server.service.labels | Extra labels for the service resource | {}
| server.platformName | The name of the configured platform account | default
| server.configMap | Custom ConfigMap name for Data Flow server configuration |
| server.trustCerts | Trust self signed certs | false

### Skipper Server Configuration

Expand All @@ -94,7 +96,10 @@ The following tables list the configurable parameters and their default values.
| skipper.imagePullPolicy | The imagePullPolicy of the Skipper server | IfNotPresent
| skipper.platformName | The name of the configured platform account | default
| skipper.service.type | The service type for the Skipper server | ClusterIP
| skipper.service.annotations | Extra annotations for service resources | {}
| skipper.service.labels | Extra labels for the service resource | {}
| skipper.configMap | Custom ConfigMap name for Skipper server configuration |
| skipper.trustCerts | Trust self signed certs | false

### Spring Cloud Deployer for Kubernetes Configuration

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,8 @@ spec:
value: 'http://${{ printf "{" }}{{ template "scdf.envname" . }}_SERVER_SERVICE_HOST}:${{ printf "{" }}{{ template "scdf.envname" . }}_SERVER_SERVICE_PORT}'
- name: SPRING_APPLICATION_JSON
value: "{ \"maven\": { \"local-repository\": null, \"remote-repositories\": { \"repo1\": { \"url\": \"https://repo.spring.io/libs-snapshot\"} } } }"
- name: KUBERNETES_TRUST_CERTIFICATES
value: {{ .Values.server.trustCerts | quote }}
volumes:
- name: database
secret:
Expand Down
3 changes: 3 additions & 0 deletions stable/spring-cloud-data-flow/templates/server-service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ metadata:
chart: "{{ .Chart.Name }}-{{ .Chart.Version }}"
release: "{{ .Release.Name }}"
heritage: "{{ .Release.Service }}"
{{- if .Values.server.service.labels }}
{{ toYaml .Values.server.service.labels | indent 4 }}
{{- end }}
{{- if .Values.server.service.annotations }}
annotations:
{{ toYaml .Values.server.service.annotations | indent 4 }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,8 @@ spec:
{{- end }}
key: rabbitmq-password
{{- end }}
- name: KUBERNETES_TRUST_CERTIFICATES
value: {{ .Values.skipper.trustCerts | quote }}
volumes:
{{- if or .Values.rabbitmq.enabled (index .Values "rabbitmq-ha" "enabled") }}
- name: rabbitmq
Expand Down
7 changes: 7 additions & 0 deletions stable/spring-cloud-data-flow/templates/skipper-service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,13 @@ metadata:
chart: "{{ .Chart.Name }}-{{ .Chart.Version }}"
release: "{{ .Release.Name }}"
heritage: "{{ .Release.Service }}"
{{- if .Values.skipper.service.labels }}
{{ toYaml .Values.skipper.service.labels | indent 4 }}
{{- end }}
{{- if .Values.skipper.service.annotations }}
annotations:
{{ toYaml .Values.skipper.service.annotations | indent 4 }}
{{- end }}
spec:
type: {{ .Values.skipper.service.type }}
ports:
Expand Down
4 changes: 4 additions & 0 deletions stable/spring-cloud-data-flow/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,12 @@ server:
version: 2.2.1.RELEASE
imagePullPolicy: IfNotPresent
platformName: default
trustCerts: false
service:
type: LoadBalancer
externalPort: 80
annotations: {}
labels: {}
configMap:
resources: {}
# limits:
Expand All @@ -41,6 +43,8 @@ skipper:
platformName: default
service:
type: ClusterIP
annotations: {}
labels: {}
configMap:
resources: {}
# limits:
Expand Down

0 comments on commit 8dc3a49

Please sign in to comment.