Skip to content

Commit

Permalink
[pg15] test: fully port regress yb_pg_select
Browse files Browse the repository at this point in the history
Summary:
Fully port regress test select to yb_pg_select.  Make use of
yb_use_hash_splitting_by_default=false and compute_query_id=regress, now
set by default for ported tests.  Of particular note is that some YB
bitmap table scans output rows in a different order from upstream PG.  I
am not aware of the cause, but I assume it has to do with how YB's
bitmap scan internals are different.

Add new yb_dep_int8_tbl for support.

Test Plan:
On Almalinux 8:

    #!/usr/bin/env bash
    set -eu
    ./yb_build.sh fastdebug --gcc11
    yes "$(grep 'PgSelect$' pg15_tests/passing_tests.tsv)" | head -50 | pg15_tests/run_tests.sh

Depends on D36352
Jenkins: rebase: pg15, test regex: TestPgRegressPgSelect

Reviewers: aagrawal, fizaa, tfoucher

Reviewed By: aagrawal

Subscribers: yql

Differential Revision: https://phorge.dev.yugabyte.com/D36354
  • Loading branch information
jaki committed Jul 10, 2024
1 parent 2c5c5e0 commit 2750e71
Show file tree
Hide file tree
Showing 6 changed files with 438 additions and 67 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
* Runs the pg_regress test suite on YB code.
*/
@RunWith(value=YBTestRunner.class)
public class TestPgRegressPgSelect extends BasePgRegressTest {
public class TestPgRegressPgSelect extends BasePgRegressTestPorted {
@Override
public int getTestMethodTimeoutSec() {
return 600;
Expand Down
19 changes: 19 additions & 0 deletions src/postgres/src/test/regress/expected/yb_dep_int8_tbl.out
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
--
-- A collection of queries to build the int8_tbl table.
--
-- The queries are taken from the relevant dependency files. Since it is
-- faster to run this rather than each file itself (e.g. dependency chain
-- test_setup, create_index), prefer using this.
--
--
-- test_setup
--
CREATE TABLE INT8_TBL(q1 int8, q2 int8);
INSERT INTO INT8_TBL VALUES
(' 123 ',' 456'),
('123 ','4567890123456789'),
('4567890123456789','123'),
(+4567890123456789,'4567890123456789'),
('+4567890123456789','-4567890123456789');
VACUUM INT8_TBL;
NOTICE: VACUUM is a no-op statement since YugabyteDB performs garbage collection of dead tuples automatically
Loading

0 comments on commit 2750e71

Please sign in to comment.