You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
timothy-e
changed the title
Dump tablegroups with tablespaces
[YSQL] Dump tablegroups with tablespaces
Oct 5, 2021
timothy-e
changed the title
[YSQL] Dump tablegroups with tablespaces
[YSQL] Dump tablegroups with tablespaces [ready for review, but blocked by cherry-pick]
Nov 30, 2021
timothy-e
changed the title
[YSQL] Dump tablegroups with tablespaces [ready for review, but blocked by cherry-pick]
[YSQL] Dump tablegroups with tablespaces
Dec 6, 2021
Summary:
The idea behind this diff is pretty simple: `ysql_dump` should include tablespaces in tablegroup declaration. However, while working on the diff, Java test framework problems were identified and fixed along the way.
Approximate summary of changes:
CXX:
* Unified `pgYbTablegroupTableExists` and `pgTablegroupTableExists`
* Populated `TablegroupInfo->grptablespace` to properly dump a tablespace.
* Declared `include-yb-metadata` flag for `ysql_dumpall` - it was used before, but wasn't properly documented.
* `yb_enable_create_with_table_oid` GUC variable is no longer needed for `ysql_dump`, removed it from the resulting dump.
Java:
* Simple process execution (output is forwarded, expect return code 0) extracted to `ProcessUtil.executeSimple`. Note that this somewhat overlaps with `CommandUtil.runShellCommand`, we'd probably want to unify them in future.
* Completely reworked `TestYsqlDump` test to align more with regression test logic. Expected files rearranged accordingly.'
Unrelated to that, removed an outdated bit from `README.md` for YSQL upgrade.
Original commit: 5198c37 / D14172
Test Plan: ybd --java-test org.yb.pgsql.TestYsqlDump
Reviewers: jason, telgersma, dsrinivasan, oleg
Reviewed By: oleg
Subscribers: yql
Differential Revision: https://phabricator.dev.yugabyte.com/D20138
Jira Link: [DB-375](https://yugabyte.atlassian.net/browse/DB-375)
respect the
--no-tablespaces
optionThe text was updated successfully, but these errors were encountered: