-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Phase 1][YSQL][Colocation] Alter table fails on colocated table #4293
Labels
Comments
The overall issue is that alter table doesn't handle non-primary tables of tablets well. Here are some details to fix it, going in time order:
See https://github.com/jaki/yugabyte-db/tree/colo-alter-table for partial work. |
ndeodhar
added a commit
that referenced
this issue
Jun 25, 2020
Summary: Add alter table support for colocated tables. Changes include: 1. AlterSchema RPC takes table ID as input. If there is no table ID, we use tablet's primary table ID. 2. SchemaPB now contains information about colocated table ID. Future diff: Tablet report sends a schema version for each tablet. Since a colocated tablet can have multiple tables, we need to send multiple schema versions (1 per table) and process that on the master. Test Plan: Added tests to yb_feature_colocation Reviewers: bogdan, hector Reviewed By: hector Subscribers: jason, yql Differential Revision: https://phabricator.dev.yugabyte.com/D8603
AbdallahKhaled93
pushed a commit
to AbdallahKhaled93/yugabyte-db
that referenced
this issue
Jun 29, 2020
Summary: Add alter table support for colocated tables. Changes include: 1. AlterSchema RPC takes table ID as input. If there is no table ID, we use tablet's primary table ID. 2. SchemaPB now contains information about colocated table ID. Future diff: Tablet report sends a schema version for each tablet. Since a colocated tablet can have multiple tables, we need to send multiple schema versions (1 per table) and process that on the master. Test Plan: Added tests to yb_feature_colocation Reviewers: bogdan, hector Reviewed By: hector Subscribers: jason, yql Differential Revision: https://phabricator.dev.yugabyte.com/D8603
deeps1991
pushed a commit
to deeps1991/yugabyte-db
that referenced
this issue
Jul 22, 2020
Summary: Add alter table support for colocated tables. Changes include: 1. AlterSchema RPC takes table ID as input. If there is no table ID, we use tablet's primary table ID. 2. SchemaPB now contains information about colocated table ID. Future diff: Tablet report sends a schema version for each tablet. Since a colocated tablet can have multiple tables, we need to send multiple schema versions (1 per table) and process that on the master. Test Plan: Added tests to yb_feature_colocation Reviewers: bogdan, hector Reviewed By: hector Subscribers: jason, yql Differential Revision: https://phabricator.dev.yugabyte.com/D8603
frozenspider
changed the title
[Colocation] Alter table fails on colocated table
[YSQL][Colocation] Alter table fails on colocated table
Apr 20, 2022
Validate this for tablegroups as well |
tverona1
changed the title
[YSQL][Colocation] Alter table fails on colocated table
[Phase 1][YSQL][Colocation] Alter table fails on colocated table
May 17, 2022
Verified - this has been fixed, ALTER works for both means of colocation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Jira Link: [DB-391](https://yugabyte.atlassian.net/browse/DB-391)
Alter table fails on colocated DB:
The text was updated successfully, but these errors were encountered: