-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[doc][2025.1] Auto analyze service tserver and master flags #25097
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for infallible-bardeen-164bc9 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some notes together with @yifanguan to try and improve clarity. Some might not be an improvement, @yifanguan to review and apply selectively.
Otherwise looks good from technical perspective.
|
||
##### ysql_cluster_level_mutation_persist_interval_ms | ||
|
||
Interval at which the reported node level table mutation counts are persisted to the underlying auto-analyze mutations table. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the "auto-analyze mutations table"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a service table the auto analyze service uses to persist its state.
@@ -987,6 +987,18 @@ expensive when the number of yb-tservers, or the number of databases goes up. | |||
|
|||
{{< /note >}} | |||
|
|||
## Auto Analyze Service flags | |||
|
|||
Auto Analyze service flags are {{<tags/feature/tp>}}. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this feature is still TP, @yifanguan, could you add an idea number to this feature tag, if there is one? See this example on how to do it: https://github.com/yugabyte/yugabyte-db/blob/3b2bac3e9288c3c68af9b89fb1c42fb8b87dbf0e/docs/content/stable/develop/best-practices-ysql.md?plain=1#L187C1-L187C358
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you do the same in other places if you have mentioned feature tags in changes?
Default: false | ||
|
||
##### ysql_enable_table_mutation_counter | ||
Enable per table mutation (INSERT, UPDATE, DELETE) counting. The Auto Analyze service runs ANALYZE when the number of mutations of a table exceeds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a new line before the heading.
This pull request add auto analyze service tserver flags
yugabyte-db/docs/content/preview/reference/configuration/yb-tserver.md
and master flags toyugabyte-db/docs/content/preview/reference/configuration/yb-master.md
DOC-527