Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e.stopPropagation() for focus synth not behaving like other events for multiple delegates #1145

Closed
lsmith opened this issue Aug 31, 2013 · 0 comments
Closed

e.stopPropagation() for focus synth not behaving like other events for multiple delegates #1145

lsmith opened this issue Aug 31, 2013 · 0 comments
Labels
bug

Comments

@lsmith
Copy link
Contributor

lsmith commented Aug 31, 2013

When there are focus delegates matching the same node, but subscribed from different containers, and the inner container's delegate callback calls e.stopPropagation(), the outer container's delegate callback is also being called. Maybe easier to understand in code: http://jsbin.com/iwAPeke/1/edit

I will issue a pull request for this momentarily.
lsmith added a commit to lsmith/yui3 that referenced this issue Aug 31, 2013
@lsmith
Fixes yui#1145. e.stopProp() edge case for focus
84e7267 
Multiple delegates for the same node were getting notified when e.stopProp()
was called, even though they were delegating from different containers. This
would be fine (delegate pretends to be individual direct subscriptions) if it
weren't inconsistent with how other events work in that scenario.
@lsmith lsmith closed this as completed Sep 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lsmith