Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calendar cell of next month appears to be selectable #1540

Closed
shunner opened this issue Jan 9, 2014 · 1 comment
Closed

Calendar cell of next month appears to be selectable #1540

shunner opened this issue Jan 9, 2014 · 1 comment
Assignees
@okuryu
Labels
bug Calendar
Milestone
Sprint 12 Code Fr...

Comments

@shunner
Copy link
Contributor

shunner commented Jan 9, 2014

As I commented in Issue #1024, I thought it's about enabled/disabled dates rules.

But after a dive in code, I found it only occurs when Feb 1st is Saturday, i.e., Mar 2nd is Sunday, and you've navigate at least once among months.

The screenshot below will tell the story.
image
The cell that represents Mar 2nd is given both yui3-calendar-day and yui3-calendar-nextmonth-day class at the same time.

Fix is on the way, just a single line of code.
shunner added a commit to shunner/yui3 that referenced this issue Jan 9, 2014
@shunner
Fix an issue the cell of next month appears to be selectable
f685f92 
Fix an issue when Feb 1st is Saturday Mar 2nd appears to be selectable.
See Issue yui#1540: yui#1540
@shunner shunner mentioned this issue Jan 9, 2014
Closed
@ghost ghost assigned okuryu Jan 9, 2014
okuryu added a commit to okuryu/yui3 that referenced this issue Jan 11, 2014
@okuryu
[calendar] Add test case for bug yui#1540
dd919cd 
Test the bug yui#1540 that the style of the day of the next month
can be selected when you are showing the next month on a calendar.
okuryu pushed a commit to okuryu/yui3 that referenced this issue Jan 12, 2014
@shunner @okuryu
Fix an issue the cell of next month appears to be selectable
74a1930 
Fix an issue when Feb 1st is Saturday Mar 2nd appears to be selectable.
See Issue yui#1540: yui#1540
@shunner shunner mentioned this issue Jan 16, 2014
Merged
@okuryu
Copy link
Member

okuryu commented Jan 16, 2014

Closing this as #1559 has merged into dev-master.

@okuryu okuryu closed this as completed Jan 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@okuryu okuryu

Labels
bug Calendar
Projects
None yet
Milestone
Sprint 12 Code Freeze
Development

No branches or pull requests
2 participants
@okuryu @shunner