-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various issues with Button #973
Comments
I've been thinking about the button type, and I think Buttons should really default to What about WidgetButton? Should we have them create |
Just wanted to let you know that I'll be on vacation until the end of the month. |
Just a heads up that I plan to dig into this once I finish up some work on a current project. Hopefully next week. |
@derek I'm back from vacation, so let me know if you want any help! |
Filed PR #1125 to improve support for single-box widgets. So now any existing node attributes (e.g. Now it appears simply changing Experimentation continues... |
PR #1125 is great for Button! Not only does this preserve the |
Yup. Classes, types, IDs, and any additional attributes and nested HTML are all preserved. The srcNode is no longer removed and replaced with the boundingBox, the srcNode is the boundingBox (as well as contentBox). |
Submitted #1163 to address checklist item 4. The Widget update (checklist item 1) was included as part of today's YUI 3.13.0 Beta 1 release. |
#1163 has been updated to clean up Y.Button & Y.ButtonCore's architecture, which I believe also addresses checklist item 2. To answer the specific issues:
ButtonCore is intended to emulate parts Widget, but not force the weight of Widget into the lowest level of the Button component. Basically, the intent is when you combine Y.ButtonCore with Y.Widget, and fill in a few additional properties (which you can see here), Y.ButtonCore becomes a Widget.
Removed.
Still a work in progress. |
Alrighty, Button is getting some love. I like the progress so far. |
Added a wiki to track ongoing Button-related work, https://github.com/yui/yui3/wiki/Button-wishlist |
First of all, let me know if I should split this into several bugs.
type
attribute (which makes them submit forms by default). I have a pull request for that, but it's incomplete.ButtonCore
has a_renderUI
method, even though it doesn't extend Widget.Button
'sHTML_PARSER.label
sets an instance variable (marked withTODO: remove
)button.js
, toggle functionality is currently not pluggablerender()
theButton
s. Withoutrender()
,bindUI()
andsyncUI()
aren't called.<button type="button"><img src="sprite.png"> Toggle</button>
(which is valid HTML), but that's not currently possible. A plugin would do the job, but as noted above,
ButtonPlugin
only provides theButtonCore
API.ButtonGroup.disable()
doesn't disable its children (I'll create a pull request for that)I'd like to work on these issues, but I need some detailed guidance.
Complete
type
attribute" - Y.Button can render as non-submit #968 , Defaulting Y.ButtonCore's template to type=button (#973, #968) #1296ButtonGroup.disable()
doesn't disable its children" - ButtonGroup.disable disables all child buttons / inputs #974The text was updated successfully, but these errors were encountered: