Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize NPCG in a regex route's matches to empty strings for undefined #1077

Merged
merged 2 commits into from
Aug 13, 2013

Conversation

ericf
Copy link
Member

@ericf ericf commented Aug 12, 2013

Fixes #1076

@ericf
Copy link
Member Author

ericf commented Aug 12, 2013

@rgrove I'm going to proceed with this change for code freeze, but we can discuss and revisit this if you have a better way to handle it. We'll just call it a "bug" in the next preview release and fix it by the final release.

@rgrove
Copy link
Contributor

rgrove commented Aug 13, 2013

Sounds good!

On Monday, August 12, 2013, Eric Ferraiuolo wrote:

@rgrove https://github.com/rgrove I'm going to proceed with this change
for code freeze, but we can discuss and revisit this if you have a better
want to handle it. We'll just call it a "bug" in the next preview release
and fix it by the final release.


Reply to this email directly or view it on GitHubhttps://github.com//pull/1077#issuecomment-22528797
.

@ericf ericf merged commit 8ca52d6 into yui:dev-master Aug 13, 2013
@ericf ericf deleted the router-npcg branch August 13, 2013 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants