[DT] Added to parse the same optional config argument that format uses. #1244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
format uses. Added tests, updated the API docs and user guide.
Said function gets cached. Dropped uses of Y.Lang.
I have to pay attention to JSHint messages. .... and so on.
While trying to write a better version I found some of the tests didn't cover some edge conditions and they didn't check the groups of numbers were not reversed or shuffled around.
Also made the error message clearer.
Making sure it doesn't break down.
Corrected as per @lsmith so that a string of nothing but whitespace now returns null and not 0 as before. Changed tests to account for this change.
…Satyam-numberparser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revamp of PR #587