Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserving [global] as [this] when executing a yui module in nodejs. #1360

Merged
merged 4 commits into from
Nov 13, 2013
Merged

Preserving [global] as [this] when executing a yui module in nodejs. #1360

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ab984c4
Preserving [global] as [this] when executing a yui module in nodejs.
caridy Oct 30, 2013
3d80c47
review feedback: removing unnecessary [] argument when calling apply()
caridy Nov 12, 2013
abb2306
adding unit test for Y.get vendor script use-case
caridy Nov 12, 2013
7534825
review feedback: newline
caridy Nov 13, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/get/js/get-nodejs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,9 @@
if (typeof YUI._getLoadHook === 'function') {
data = YUI._getLoadHook(data, url);
}
mod._compile('module.exports = function (YUI) {' + data + '\n;return YUI;};', url);
mod._compile('module.exports = function (YUI) {' +
'return (function () {'+ data + '\n;return YUI;}).apply(global);' +
'};', url);

/*global YUI:true */
YUI = mod.exports(YUI);
Expand Down
10 changes: 10 additions & 0 deletions src/get/tests/assets/vendor-signed.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
// script trying to store a global variable called `foo`
(function (global) {
global.foo = 1;
}(this));

// signing the vendor script with a YUI module name
// and optionally, adding the value of `foo` to the namespace
YUI.add('vendor-script-signed', function (Y) {
Y.foo = Y.config.global.foo;
}, '', {});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newline.

35 changes: 35 additions & 0 deletions src/get/tests/cli/run.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
#!/usr/bin/env node

process.chdir(__dirname);

var YUITest = require('yuitest'),
path = require('path'),
fs = require('fs'),
dir = path.join(__dirname, '../../../../build-npm/'),
YUI = require(dir).YUI,
json;

YUI({ useSync: true }).use('test', function(Y) {
Y.Test.Runner = YUITest.TestRunner;
Y.Test.Case = YUITest.TestCase;
Y.Test.Suite = YUITest.TestSuite;
Y.Assert = YUITest.Assert;

Y.applyConfig({
modules: {
'get-vendor-test': {
fullpath: path.join(__dirname, '../unit/assets/vendor-test.js'),
requires: ['get', 'vendor-script-signed', 'test']
},
'vendor-script-signed': {
fullpath: path.join(__dirname, '../assets/vendor-signed.js')
}
}
});

Y.use('get-vendor-test');

Y.Test.Runner.setName('get cli tests');
Y.Test.Runner.add(Y.GetTests.vendor);

});
15 changes: 15 additions & 0 deletions src/get/tests/unit/assets/vendor-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
YUI.add('get-vendor-test', function (Y) {

Y.GetTests = new Y.Test.Suite("get vendor");

Y.GetTests.vendor = new Y.Test.Case({
name: "Y.get vendor tests",

'test: global to work across runtimes' : function() {
Y.Assert.areEqual(1, Y.foo, 'Y.config.global.foo is not set correctly');
}
});

}, '', {
requires: ['get', 'vendor-script-signed', 'test']
});
31 changes: 31 additions & 0 deletions src/get/tests/unit/vendor.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/html4/strict.dtd">
<html>
<head>
<title>YUI Get Vendor Tests</title>
</head>
<body class="yui3-skin-sam">

<div id="log"></div>

<script src="../../../../build/yui/yui.js"></script>
<script src="../assets/vendor-signed.js" charset="utf-8"></script>
<script src="./assets/vendor-test.js" charset="utf-8"></script>

<script>
var YUI_config = {
gconfig: true,
gfilter: (window.location.search.match(/[?&]filter=([^&]+)/) || [])[1] || 'raw'
};

var Y = YUI({
allowRollup: false,
filter: YUI_config.gfilter
}).use('get-vendor-test', 'test-console', function(Y) {
new Y.Test.Console().render('#log');
Y.Test.Runner.add(Y.GetTests.vendor);
Y.Test.Runner.run();
});
</script>

</body>
</html>