Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2531655 oop.dispatch public #139

Closed
wants to merge 3 commits into from
Closed

Conversation

jafl
Copy link
Contributor

@jafl jafl commented May 15, 2012

No description provided.

@travisbot
Copy link

This pull request passes (merged a8052c7 into aa2d5e6).

@sdesai
Copy link
Contributor

sdesai commented May 15, 2012

Thanks. Will look at pulling this in.

@ghost ghost assigned sdesai May 21, 2012
@sdesai
Copy link
Contributor

sdesai commented Sep 20, 2012

Putting into the backlog for the next sprint, starting 9/25/12

@ghost ghost assigned tilomitra Dec 20, 2012
@tilomitra
Copy link
Contributor

Hey @jafl, after looking through the discussion on this ticket, I think the best fix here is to make sure Y.Array.each supports NodeLists and ModelLists. This sounds like a better fix than using Y.each and Y.some generically (as mentioned in the thread).

I'll close this for now. Feel free to create a ticket asking for Y.Array.each support for NodeLists and ModelLists. I think that makes sense.

@tilomitra tilomitra closed this Jan 9, 2013
@jafl
Copy link
Contributor Author

jafl commented Jan 9, 2013

Please reconsider.

The point of this pull request was not specifically Y.each. The point was to expose a method that can be used to implement all the functions like Y.map, Y.filter, Y.reject, Y.partition, etc.

From my comments in the ticket:

While I agree that in some cases, iteration may matter for Y.some, Y.every, and Y.reduce, the whole point of Y.each, Y.map, Y.filter, Y.reject, Y.partition is that iteration order is irrelevant. They are trivially parallelizable -- no matter that JavaScript is single threaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants