Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow for web urls. a windows only issue? #223

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

frostbitten
Copy link

I was not able to pull a file from a url but this this edit I was. On windows.

@tml
Copy link
Contributor

tml commented Dec 9, 2015

An interesting idea - can you give an example of how you're using this?

@frostbitten
Copy link
Author

Sure. I'm using a framework that has page schemas. I define a list of resources and they get loaded depending on the page. The framework also has the option to minify these sources. A problem can occur with this as external resources are not included in the min file and just linked as separate resources after the min file. If the order of the loaded resources is important (as it often is) then this minifaction process can be pointless for some page groups. With this mod, however, all of the resources can be put into the one minified file and in the correct order at once.

@frostbitten
Copy link
Author

this mod, however, does create an attack vector by means of man-in-the-middle, or if the hosts file on a windows server were tampered with. It would seem trusted intranet-served files would be the only safe resources to pull via this method. With that said, I'm not sure if this could be implemented without creating a security hole for those who might misuse it. =\

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants