Allow a base url for external links #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the ability to specify a base url for a given data.json to be
used when constructing urls for external links. For example:
external: {
data: [
{
base: 'http://emberjs.com/api/',
json: 'http://builds.emberjs.com/tags/v1.5.1/ember-docs.json'
},
{
base: 'http://emberjs.com/api/',
json: 'http://builds.emberjs.com/tags/v1.0.0-beta.6/ember-data-docs.json'
}
]
}
This is not breaking. For example, the following is still valid:
external: {
data: [
'http://builds.emberjs.com/tags/v1.5.1/ember-docs.json'
]
}
|
I just confirmed to passed tests. Looks good to me. @caridy I'd like to merge this. |
|
LGTM |
|
CLA is valid! |
Closed
|
@mmpestorich I just merged, it will be available in the next version. Thanks for your contribution! 👍 |
okuryu
added a commit
to okuryu/yuidoc
that referenced
this pull request
Nov 5, 2014
This feature implemented in yui#253.
okuryu
added a commit
to okuryu/yuidoc
that referenced
this pull request
Nov 5, 2014
This feature implemented in yui#253.
This was referenced Nov 5, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addressed issue #237 and adds the ability to specify a base url for a given data.json to be
used when constructing urls for external links. For example:
This is not breaking. For example, the following is still valid: