Adds support for \* in REGEX_LINE_HEAD_CHAR..
#287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows for the alternative coffeescript syntax: ###* * * ###
|
Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! 😄 |
|
Added CLA. As noted I am not fully aware how testing is meant to be done but I have added a sample test file if anyone can help me write the appropriate test case. |
|
CLA is valid! |
|
Thanks for your PR! It seems to need to tweak the parser tests (tests/parser_coffee.js). I'll try to do it after merge this. 👍 |
|
Thanks! |
okuryu
added a commit
to okuryu/yuidoc
that referenced
this pull request
Nov 26, 2014
This tests changes is for PR yui#287.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tweaked the regex to allow for more flexibility in coffeescript comments.
I'd really like to see this feature in the parser as it allows for easier interoperability with the Coffeescript syntax generated in Sublime Text using the DocBlockr plugin (https://github.com/spadgos/sublime-jsdocs)
One problem I'm having though is getting my test cases integrated. Any help with that would be very much appreciated.