Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use res.status(status).send(body) instead of res.send(body, status) #306

Merged
merged 1 commit into from
Jan 7, 2015

Conversation

okuryu
Copy link
Member

@okuryu okuryu commented Jan 3, 2015

YUIDoc is using res.send(body, status) method of Express, but it have been deprecated since Express 4.7.0, and it returns following warning for now. It should use res.status(status).send(body) instead.

express deprecated res.send(body, status): Use res.status(status).send(body) instead

See also: https://github.com/strongloop/express/blob/master/History.md#470--2014-07-25

YUIDoc is using `res.send(body, status)` method of Express, but it have been
deprecated since Express 4.7.0, and it returns following warning for now.
It should use `res.status(status).send(body)` instead.

```
express deprecated res.send(body, status): Use res.status(status).send(body) instead
```

See also: https://github.com/strongloop/express/blob/master/History.md#470--2014-07-25
@yahoocla
Copy link

yahoocla commented Jan 3, 2015

CLA is valid!

@okuryu okuryu self-assigned this Jan 4, 2015
@okuryu okuryu modified the milestone: v0.5.0 Jan 5, 2015
@okuryu okuryu merged commit 1e685fa into yui:master Jan 7, 2015
@okuryu okuryu deleted the express-status branch January 7, 2015 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants