Adds @implements and @interface tags #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA is valid! |
|
I'm not able to verify that this fixes the warning. Did you tested this? |
|
yes i tested it, a complete implementation of @interface @implements would be nice but this will work for now, should I open a issue for that? |
|
@okuryu i see the prob, i accidentally put an @ in the string in docparser should of been just "implements" vs "@implements" |
| 'writeonce' // YUI attribute config | ||
| 'writeonce', // YUI attribute config | ||
| 'implements', // Implements Interface | ||
| 'interface' // Is Interface |
There was a problem hiding this comment.
Can you make alphanumerics sort?
Signed-off-by: Mathew Zummo <mzummo@gmail.com>
|
@okuryu should be good to go |
|
Merged. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tags to suppress warnings on doc build. Can be parsed out as well from json docs
Signed-off-by: Mathew Zummo mzummo@gmail.com