Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import utility script for MDN links #363

Merged
merged 1 commit into from
Jul 7, 2015
Merged

Conversation

andyearnshaw
Copy link
Contributor

Implements #354. A utility script is provided to update the native links, which can then be committed to the repo. In the future, this could be improved to update the links at compile time so that they are always fresh.

@yahoocla
Copy link

Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! 😄

@okuryu
Copy link
Member

okuryu commented Jun 30, 2015

Thanks for your doing! I think that we can make this feature as one npm module.

@andyearnshaw
Copy link
Contributor Author

Interesting. I don't mind moving the code into an npm package, but how do
you propose it would work? Would it update the native links via an exported
method and cache the result?

On Tue, 30 Jun 2015 07:06 Ryuichi Okumura notifications@github.com wrote:

Thanks for your doing! I think that we can make this feature as one npm
module.


Reply to this email directly or view it on GitHub
#363 (comment).

@andyearnshaw
Copy link
Contributor Author

I've created a basic NPM package with a couple of methods. How would you like to proceed with utilising this package in YUIDoc?

https://www.npmjs.com/package/mdn-links

@okuryu
Copy link
Member

okuryu commented Jul 1, 2015

Cool! This is close to what I was thinking. It looks YUIDoc is able to depends on this and use it. What do you think?

@andyearnshaw
Copy link
Contributor Author

That's what I was hoping for ;-) I'm just not sure about updating at
compile time. My PR avoided this for now in favour of just using static
data, shall I rework the PR to do this with the npm module?

On Wed, 1 Jul 2015 13:51 Ryuichi Okumura notifications@github.com wrote:

Cool! This is close to what I was thinking. It looks YUIDoc is able to
depends on this and use it. What do you think?


Reply to this email directly or view it on GitHub
#363 (comment).

@okuryu
Copy link
Member

okuryu commented Jul 1, 2015

Aha, doesn't your mdn-links module has static data? if so, it should has the static data.

@okuryu
Copy link
Member

okuryu commented Jul 2, 2015

getLink() method looks returns static data. This doen't requres any compile time. I'm ok with using this method.

@andyearnshaw
Copy link
Contributor Author

It does, but it also provides an update method to freshen the data. Once
I'm done at ReactEurope I'll update the PR.

On Wed, 1 Jul 2015 16:38 Ryuichi Okumura notifications@github.com wrote:

Aha, doesn't your mdn-links module has static data? if so, it should has
the static data.


Reply to this email directly or view it on GitHub
#363 (comment).

@andyearnshaw
Copy link
Contributor Author

Updated and rebased, should be ready to go.

@okuryu
Copy link
Member

okuryu commented Jul 6, 2015

Thanks! I'll take a look in this week.

@okuryu
Copy link
Member

okuryu commented Jul 7, 2015

It looks good to me. Thanks!

@okuryu okuryu merged commit 83c0b6e into yui:master Jul 7, 2015
@okuryu okuryu mentioned this pull request Jul 7, 2015
@okuryu okuryu added this to the v0.8.0 milestone Jul 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants