-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump dive
image version to 0.12
, fix --ci-config
and other issues
#373
base: main
Are you sure you want to change the base?
Conversation
--ci-config
dive
image version to 0.10
and fix --ci-config
dive
image version to 0.10
and fix --ci-config
dive
image version to 0.10
and fix --ci-config
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Maksym Vlasov <MaxymVlasov@users.noreply.github.com>
…0, bump wagoodman/dive to v0.12 (#16) * Update deps via `nmp outdated` and then `npm update --package-lock-only` * Bump node from 12 to 20 * Bump DOCKER_API_VERSION to 1.45 * Bump wagoodman/dive docker image to v0.12
WalkthroughThis update includes several significant changes: configuration of Renovate for dependency management, upgrading Node.js from version 12 to 20 in Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (3)
dist/index.js
is excluded by!**/dist/**
dist/index.js.map
is excluded by!**/dist/**
,!**/*.map
package-lock.json
is excluded by!**/package-lock.json
Files selected for processing (4)
- .github/renovate.json5 (1 hunks)
- action.yml (1 hunks)
- package.json (1 hunks)
- src/main.ts (2 hunks)
Files skipped from review due to trivial changes (2)
- .github/renovate.json5
- action.yml
Additional comments not posted (16)
package.json (13)
34-34
: Version bump for@actions/github
from^4.0.0
to^6.0.0
looks good.
38-38
: Version bump for@types/jest
from^27.4.1
to^29.5.12
looks good.
39-39
: Version bump for@types/node
from^17.0.24
to^20.14.6
looks good.
40-40
: Version bump for@typescript-eslint/parser
from^4.33.0
to^7.13.1
looks good.
41-41
: Version bump for@vercel/ncc
from^0.33.4
to^0.38.1
looks good.
42-42
: Version bump foreslint
from^7.32.0
to^8.5.0
looks good.
43-43
: Version bump foreslint-plugin-github
from^4.1.5
to^5.0.1
looks good.
44-44
: Version bump foreslint-plugin-jest
from^26.1.4
to^28.6.0
looks good.
45-45
: Version bump forjest
from^26.6.3
to^29.7.0
looks good.
46-46
: Version bump forjest-circus
from^27.5.1
to^29.7.0
looks good.
48-48
: Version bump forprettier
from^2.6.2
to^3.3.2
looks good.
49-49
: Version bump forts-jest
from^26.5.6
to^29.1.5
looks good.
50-50
: Version bump fortypescript
from^4.3.5
to^5.4.5
looks good.src/main.ts (3)
51-51
: Update todiveImage
version fromv0.9
tov0.12
aligns with the latest stable release.
58-58
: Update toDOCKER_API_VERSION
from1.37
to1.45
ensures compatibility with the latest Docker features.
73-73
: Correct placement of--ci-config
after the image tag resolves the issue reported in #194.
dive
image version to 0.10
and fix --ci-config
dive
image version to 0.12
, fix --ci-config
and other issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range and nitpick comments (2)
README.md (2)
Line range hint
48-48
: Consider adding "the" before "dive config file".- There are three metrics supported by dive config file. + There are three metrics supported by the dive config file.This minor grammatical correction improves the readability of the documentation.
Line range hint
68-68
: Specify the language for the fenced code block.- ```yaml + ```yaml rules:It's a best practice to specify the language for code blocks to enable syntax highlighting, which improves readability.
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- LICENSE (1 hunks)
- README.md (2 hunks)
Files skipped from review due to trivial changes (1)
- LICENSE
Additional context used
LanguageTool
README.md
[uncategorized] ~48-~48: You might be missing the article “the” here. (AI_EN_LECTOR_MISSING_DETERMINER_THE)
Context: ...e There are three metrics supported by dive config file. See [here](https://github....
Markdownlint
README.md
9-9: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
68-68: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
Additional comments not posted (4)
README.md (4)
27-27
: Update the event trigger topull_request
for GitHub Actions.This change aligns with the PR's intention to optimize the workflow for pull request events, enhancing the CI process by triggering actions only when necessary.
35-35
: Updated checkout action to v4.This update ensures compatibility with the latest features and security fixes provided by GitHub Actions. It's good practice to keep these dependencies up-to-date.
39-39
: Updated thedive-action
to version1.0.0
.This change points to the updated version of
dive-action
which likely includes the fixes and enhancements mentioned in the PR, such as the correct handling of the--ci-config
parameter.
134-139
: Update references and badges to reflect the new repository owner.The updated links and badges ensure users are directed to the correct repository and can see the latest release information. This is crucial for maintaining the accuracy and trustworthiness of the documentation.
chore: Became a maintainer of that GHA
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (3)
dist/index.js
is excluded by!**/dist/**
dist/index.js.map
is excluded by!**/dist/**
,!**/*.map
dist/sourcemap-register.js
is excluded by!**/dist/**
Files selected for processing (12)
- .editorconfig (1 hunks)
- .eslintrc.json (1 hunks)
- .github/codeql/config.yml (1 hunks)
- .github/renovate.json5 (1 hunks)
- .github/workflows/automerge.yml (1 hunks)
- .github/workflows/codeql-analysis.yml (3 hunks)
- .github/workflows/test.yml (1 hunks)
- .pre-commit-config.yaml (1 hunks)
- .prettierignore (1 hunks)
- .prettierrc.json (1 hunks)
- action.yml (2 hunks)
- src/main.ts (3 hunks)
Files skipped from review due to trivial changes (9)
- .editorconfig
- .eslintrc.json
- .github/codeql/config.yml
- .github/workflows/automerge.yml
- .github/workflows/codeql-analysis.yml
- .github/workflows/test.yml
- .pre-commit-config.yaml
- .prettierignore
- .prettierrc.json
Files skipped from review as they are similar to previous changes (3)
- .github/renovate.json5
- action.yml
- src/main.ts
Close #194 #204
I didn't find a working fork, so create this, very straightforward fix.
Note: No TS->JS translation, I made all needed changes manually (
.js.map
not needed for action, so it not completely changed)Tested in this commit and PR
If someone need working action before this PR will not be merged, feel free to use
Summary by CodeRabbit
New Features
Updates
Improvements
Documentation
Miscellaneous