Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix os.date("!*t", os.time()) will not get UTC date time issue #433

Merged
merged 3 commits into from
May 30, 2023
Merged

fix: fix os.date("!*t", os.time()) will not get UTC date time issue #433

merged 3 commits into from
May 30, 2023

Conversation

ttys3
Copy link
Contributor

@ttys3 ttys3 commented Apr 12, 2023

Fixes os.date("!*t", os.time()) will not get UTC date time issue

yuin
yuin requested changes May 29, 2023
View reviewed changes
baselib_test.go Show resolved Hide resolved
@ttys3 ttys3 requested a review from yuin May 30, 2023 06:38
@yuin
Copy link
Owner

yuin commented May 30, 2023

@ttys3 Sorry for misunderstanding your PR.
I had thought os.Setenv but you used t.Setenv so you do not need to rollback the TZ envvar.
Could you add t.Setenv again?

@ttys3
Copy link
Contributor Author

ttys3 commented May 30, 2023

@ttys3 Sorry for misunderstanding your PR. I had thought os.Setenv but you used t.Setenv so you do not need to rollback the TZ envvar. Could you add t.Setenv again?

done. PTAL

@yuin yuin merged commit 2b3f02d into yuin:master May 30, 2023
@mikefero mikefero mentioned this pull request Sep 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuin yuin Awaiting requested review from yuin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ttys3 @yuin